On Thu, Mar 5, 2020 at 7:21 PM Dey, Souvik <[email protected]> wrote: > > Thanks will do that. And will also try to remove the trailer in the patches. > Thanks for pointing it out. > > From: dev <[email protected]> On Behalf Of Rasesh Mody > Sent: Tuesday, March 3, 2020 6:01 PM > To: Dey, Souvik <[email protected]>; Shahed Shaikh <[email protected]>; Jerin > Jacob Kollanukkaran <[email protected]>; [email protected]; > [email protected] > Cc: [email protected]; [email protected] > Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV > case
1) Please change vlan to VLAN 2) Fix the following checkpatch issue. Probably move the new code to a new function to get enough space. [master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh ### net/bnx2x: handle guest VLAN for SR-IOV case WARNING:BAD_SIGN_OFF: email address '"Dey Souvik" <[email protected]>' might be better as 'Dey Souvik <[email protected]>' #16: Signed-off-by: "Dey Souvik" <[email protected]> WARNING:LONG_LINE_COMMENT: line over 80 characters #27: FILE: drivers/net/bnx2x/bnx2x.c:2219: + /* when transmitting in a vf, start bd must hold the ethertype WARNING:LONG_LINE: line over 80 characters #36: FILE: drivers/net/bnx2x/bnx2x.c:2225: + if (eh->ether_type == rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) { WARNING:LONG_LINE: line over 80 characters #41: FILE: drivers/net/bnx2x/bnx2x.c:2230: + ETH_TX_BD_FLAGS_VLAN_MODE_SHIFT); WARNING:LONG_LINE: line over 80 characters #47: FILE: drivers/net/bnx2x/bnx2x.c:2236: + (rte_be_to_cpu_16(eh->ether_type))); WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Dey, Souvik <[email protected]>' total: 0 errors, 6 warnings, 0 checks, 28 lines checked 0/1 valid patch ----------------------------------------------------------------------------
