On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > Hi, > >> -----Original Message----- >> From: Ophir Munk <ophi...@mellanox.com> >> Sent: Monday, March 30, 2020 1:32 AM >> To: dev@dpdk.org; Matan Azrad <ma...@mellanox.com> >> Cc: Thomas Monjalon <tho...@monjalon.net>; Olga Shern >> <ol...@mellanox.com>; Raslan Darawsheh <rasl...@mellanox.com>; Ophir >> Munk <ophi...@mellanox.com>; Asaf Penso <as...@mellanox.com> >> Subject: [PATCH v1] common/mlx5: remove devx depndency on ibv and dv >> >> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS >> agnostic and not include any references to ibv or dv structs (defined in >> ibverbs and rdma-core linux libraries). This commit replaces all ibv and >> dv references with 'void *'. Specifically, the following struct were >> replaced: >> 1. struct ibv_context * >> 2. struct ibv_qp * >> 3. struct mlx5dv_devx_cmd_comp * >> >> Signed-off-by: Ophir Munk <ophi...@mellanox.com> > > Patch applied to next-net-mlx, >
Hi David, This patch is failing in the travis for ABI checks [1], since mlx has APIs now [2], are they public APIs or internal ones, and are they part of the ABI policy, can you please check this? @Thomas, please don't pull from next-net until this resolved, since this patch is merged into next-net. Thanks, ferruh [1] [C]'function mlx5_devx_obj* mlx5_devx_cmd_create_cq(ibv_context*, mlx5_devx_cq_attr*)' at mlx5_devx_cmds.c:1153:1 has some indirect sub-type changes: parameter 1 of type 'ibv_context*' changed: in pointed to type 'struct ibv_context': entity changed from 'struct ibv_context' to 'void' type size changed from 2624 to 0 (in bits) <multiple similar warnings> [2] https://git.dpdk.org/dpdk/tree/drivers/common/mlx5/rte_common_mlx5_version.map?h=v20.02#n6