On Wed, Apr 08, 2020 at 07:16:10PM +0100, Wiles, Keith wrote: > > > > On Apr 8, 2020, at 11:49 AM, Power, Ciara <ciara.po...@intel.com> wrote: > > > > From: Bruce Richardson <bruce.richard...@intel.com> > > > > The ethdev library now registers commands with telemetry, and > > implements the callback functions. These commands allow the list of > > ethdev ports and the stats and link status for a port to be queried. > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > Signed-off-by: Ciara Power <ciara.po...@intel.com> > > > > --- > > v2: > > - Renamed stats to xstats for device specific stats. > > - Added link status command for ethdev ports. > > --- > > lib/librte_ethdev/Makefile | 4 ++ > > lib/librte_ethdev/meson.build | 4 ++ > > lib/librte_ethdev/rte_ethdev.c | 106 +++++++++++++++++++++++++++++++++ > > 3 files changed, 114 insertions(+) > > <snip> > + > > +if (link.link_status) > > +ret = snprintf(buffer, buf_len, > > +"{\"status\":\"%s\", \"speed\":%u, \"duplex\":" > > +"\"%s\"}", link.link_status ? "UP" : "DOWN:", > > +link.link_speed, > > +(link.link_duplex == ETH_LINK_FULL_DUPLEX) ? > > +("full-duplex") : ("half-duplex")); > > Adding link status nice. Please remove the spaces in the output string. > Good catch, thanks.
- [dpdk-dev] [PATCH v2 03/16] metrics: reduce code taken fr... Ciara Power
- [dpdk-dev] [PATCH v2 02/16] telemetry: move code to metri... Ciara Power
- [dpdk-dev] [PATCH v2 04/16] telemetry: invert dependency ... Ciara Power
- Re: [dpdk-dev] [PATCH v2 04/16] telemetry: invert de... Pattan, Reshma
- [dpdk-dev] [PATCH v2 07/16] app/test: add telemetry json ... Ciara Power
- [dpdk-dev] [PATCH v2 06/16] telemetry: add utility functi... Ciara Power
- Re: [dpdk-dev] [PATCH v2 06/16] telemetry: add utili... Wiles, Keith
- Re: [dpdk-dev] [PATCH v2 06/16] telemetry: add u... Bruce Richardson
- [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support ... Ciara Power
- Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add callback... Wiles, Keith
- Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add call... Bruce Richardson
- Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add ... Morten Brørup
- [dpdk-dev] [PATCH v2 05/16] telemetry: introduce new tele... Ciara Power
- [dpdk-dev] [PATCH v2 09/16] usertools: add new telemetry ... Ciara Power
- Re: [dpdk-dev] [PATCH v2 09/16] usertools: add new t... Pattan, Reshma
- Re: [dpdk-dev] [PATCH v2 09/16] usertools: add n... Bruce Richardson
- [dpdk-dev] [PATCH v2 11/16] examples/l3fwd-power: enable ... Ciara Power
- Re: [dpdk-dev] [PATCH v2 11/16] examples/l3fwd-power... Pattan, Reshma
- [dpdk-dev] [PATCH v2 12/16] telemetry: introduce telemetr... Ciara Power
- Re: [dpdk-dev] [PATCH v2 12/16] telemetry: introduce... Pattan, Reshma