09/04/2020 14:03, Ferruh Yigit: > On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > > - pkt_burst_stats_display("RX", &fs->rx_burst_stats); > > - pkt_burst_stats_display("TX", &fs->tx_burst_stats); > > + pkt_burst_stats_display(false, &fs->rx_burst_stats); > > + pkt_burst_stats_display(true, &fs->tx_burst_stats); > > Instead of this true/false, I would be OK to some duplication and have > explicit > Rx/Tx, I believe it would be more clear that way, but no strong opinion on it.
I have a strong opinion here: Rx/Tx is not a boolean. If not a string, it should be a constant (#define).