On Thu, Apr 09, 2020 at 12:59:50PM +0200, Thomas Monjalon wrote: > 09/04/2020 12:45, Ray Kinsella: > > On 09/04/2020 11:43, Bruce Richardson wrote: > > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > > >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > > >>> On 08/04/2020 20:56, Neil Horman wrote: > > >>>> +The syntax of the ``check-abi.sh`` utility is:: > > >>>> + > > >>>> + ./devtools/check-abi.sh <refdir> <newdir> > > >>> > > >>> (from v1 feedback) > > >>> Could we simplify this all greatly, by telling people to use the > > >>> meson/ninja build, > > >>> so they get this checking out of the box, without all the headache > > >>> below? > > >>> > > >> I think bruce noted that was never merged, correct? > > >> > > > Yep, correct. :-( > > > > apologies, was there a reason? > > Because build tool job is building, not checking. > It would be wrong to make (slow) checks mandatory in all builds. > > The need is to enforce checking ABI. > The result is already published by Travis in patchwork and in an > email to the author I believe. > Not checking email and patchwork is not a good excuse. > > Patchwork must be a mandatory read for everybody for all checks > in general. Let's not give up on general CI workflow. > But it would be helpful to at least codify the commands in the example patch into a build target, for the convienience of local checking prior to CI submission, no? Neil
> > >
