09/04/2020 15:10, Jerin Jacob: > > * tracing library > > * Some concerns on the API, it is copy/paste of log API > > The following API signatures are taken from log API. > > 1) void rte_trace_global_level_set(uint32_t level); > 2) uint32_t rte_trace_global_level_get(void); > 3) uint32_t rte_trace_level_get(rte_trace_t trace); > 4) int rte_trace_level_set(rte_trace_t trace, uint32_t level); > 5) int rte_trace_pattern(const char *pattern, bool enable); > 6) int rte_trace_regexp(const char *regex, bool enable); > > I have intentionally kept public API similar to rte_log wherever it is > possible. Reason being, > > 1) In the future, it is easy to replace rte_log with trace _if needed_. > 2) Avoid the new API learning curve. > 3) I did not find anything wrong with the existing log API to improve > on at least on API that selected to copy the prototype. > > If there are specific comments on why we need to take the deviation > from log API on the above schematics. I am happy to change it.
Please remove global level. We'll try to remove it from rte_log as well. Let's continue discussion in the patch thread.
