> -----Original Message----- > From: dev <[email protected]> On Behalf Of Alexander Kozyrev > Sent: Friday, April 10, 2020 1:21 > To: Mohsin Shaikh <[email protected]>; [email protected] > Cc: [email protected] > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib > stat > > > -----Original Message----- > > From: Mohsin Shaikh <[email protected]> > > Sent: Thursday, April 9, 2020 16:37 > > To: [email protected] > > Cc: [email protected]; Alexander Kozyrev <[email protected]>; > Mohsin > > Shaikh <[email protected]> > > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat > > > > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to > > TLB shootdown interrupts to all dpdk app cores including RX cores. > > This can cause packet drops. Use read(2)/write(2) instead. > > > > Bugzilla ID: 440 > > Cc: [email protected] > > > > Signed-off-by: Mohsin Shaikh <[email protected]> > > --- > > Reviewed-by: Alexander Kozyrev <[email protected]> Acked-by: Viacheslav Ovsiienko <[email protected]>
Thank you, Mohsin for the patch. Alexander, thank you for the review and test. With best regards, Slava
