On Sun, Apr 12, 2020 at 9:03 AM Tonghao Zhang <[email protected]> wrote: > > On Sun, Apr 12, 2020 at 11:20 AM Tonghao Zhang <[email protected]> > wrote: > > > > On Fri, Apr 10, 2020 at 9:11 PM Jerin Jacob <[email protected]> wrote: > > > > > > On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob <[email protected]> > > > wrote: > > > > > > > > > > Three more items are missing in this patch > Can I add "Co-authored-by" for you ?
We are not using that tag in DPDK. Feel free to add, Suggested-by: Jerin Jacob <[email protected]> > > > > 1) Unit test case for new API > > > 2) Make the new API __rte_experimal > > Hi Jerin > > This API will be invoked in mempool, if use that prefix, there is a > > compile warning: > > include/rte_mempool.h:933:2: error: ‘rte_init_register’ is deprecated > > (declared at x86_64-native-linuxapp-gcc/include/rte_init.h:61): Symbol > > is not yet part of stable ABI [-Werror=deprecated-declarations] http://patches.dpdk.org/patch/68119/ will be applied soon. So it will not a problem,
