Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Monday, April 13, 2020 20:18 > To: Wang, Haiyue <haiyue.w...@intel.com> > Cc: dev@dpdk.org; vattun...@marvell.com; jer...@marvell.com; > alex.william...@redhat.com; > david.march...@redhat.com > Subject: Re: [PATCH v4] eal: add VFIO-PCI SR-IOV support > > Hi, > > About the title, I think it does not convey what is new here. > VFIO is not new, SR-IOV is already supported. > The title should mention the new VFIO feature in few simple words. > Is it only about using VFIO for PF? >
For Both. Align with Alex's : vfio-pci: QEMU support for vfio-pci VF tokens How about: 'eal: support for VFIO-PCI VF tokens' ? > > 13/04/2020 10:29, Haiyue Wang: > > v4: 1. Ignore rte_vfio_setup_device ABI check since it is > > for Linux driver use. > [...] > > +; Ignore this function which is only relevant to linux for driver > > +[suppress_type] > > + name = rte_vfio_setup_device > > Adding such exception for all internal "driver interface" functions > is not scaling. Please use __rte_internal. > I am waiting for the patchset about rte_internal to be reviewed or completed. > As it is not progressing, the decision is to block any patch having > ABI issue because of internal false positive. > Please help, thanks. > I will drop this patch ABI workaround, and try to catch the '__rte_internal ' design.
