hi, stephen
On 4/16/2020 12:31 AM, Stephen Hemminger wrote:
On Tue, 14 Apr 2020 09:48:31 +0000 Ori Kam <[email protected]> wrote:@@ -2299,6 +2299,22 @@ cmd_config_rss_parsed(void *parsed_result, rss_conf.rss_hf = ETH_RSS_L4_SRC_ONLY; else if (!strcmp(res->value, "l4-dst-only")) rss_conf.rss_hf = ETH_RSS_L4_DST_ONLY; + else if (!strcmp(res->value, "eth-src-only")) + rss_conf.rss_hf = ETH_RSS_ETH_SRC_ONLY; + else if (!strcmp(res->value, "eth-dst-only")) + rss_conf.rss_hf = ETH_RSS_ETH_DST_ONLY; + else if (!strcmp(res->value, "s-vlan")) + rss_conf.rss_hf = ETH_RSS_S_VLAN; + else if (!strcmp(res->value, "c-vlan")) + rss_conf.rss_hf = ETH_RSS_C_VLAN; + else if (!strcmp(res->value, "l2tpv3")) + rss_conf.rss_hf = ETH_RSS_L2TPV3; + else if (!strcmp(res->value, "esp")) + rss_conf.rss_hf = ETH_RSS_ESP; + else if (!strcmp(res->value, "ah")) + rss_conf.rss_hf = ETH_RSS_AH; + else if (!strcmp(res->value, "pfcp")) + rss_conf.rss_hf = ETH_RSS_PFCP;Hasn't this grown big enough that it should be a table with lookup function, versus a cascade of strcmp's.
I suppose what you said is make sense, but would you mind if a next coming specific patch to fix it but not involve in this feature patch set?
