Hi Fiona,

> -----Original Message-----
> From: Trahe, Fiona <[email protected]>
> Sent: Thursday, April 16, 2020 5:26 PM
> To: De Lara Guarch, Pablo <[email protected]>; Doherty, Declan
> <[email protected]>
> Cc: [email protected]; [email protected]; De Lara Guarch, Pablo
> <[email protected]>; Dybkowski, AdamX
> <[email protected]>; Trahe, Fiona <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check
> 
> Hi Pablo,
> 
> > -----Original Message-----
> > From: dev <[email protected]> On Behalf Of Pablo de Lara
> > Sent: Thursday, April 16, 2020 10:08 AM
> > To: Doherty, Declan <[email protected]>
> > Cc: [email protected]; [email protected]; De Lara Guarch, Pablo
> > <[email protected]>; Dybkowski, AdamX
> > <[email protected]>
> > Subject: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check
> 
> ///snip///
> > +static int
> >  test_blockcipher_one_case(const struct blockcipher_test_case *t,
> >     struct rte_mempool *mbuf_pool,
> >     struct rte_mempool *op_mpool,
> > @@ -93,11 +136,13 @@ test_blockcipher_one_case(const struct
> blockcipher_test_case *t,
> >             uint64_t feat_flags = dev_info.feature_flags;
> >             uint64_t oop_flag =
> RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT;
> >
> > -           if (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) {
> > +           if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_OOP) {
> [Fiona] Isn't this a fix which should be a separate patch and should be
> backported to stable releases?

Yes, you are right. I will send a separate patch for this then.

Thanks!
Pablo

Reply via email to