Hi Thomas & David,
> -----Original Message-----
> From: Thomas Monjalon <[email protected]>
> Sent: Tuesday, April 21, 2020 01:43
> To: Wang, Haiyue <[email protected]>
> Cc: Neil Horman <[email protected]>; David Marchand
> <[email protected]>; dev
> <[email protected]>; Burakov, Anatoly <[email protected]>; Vamsi Attunuru
> <[email protected]>;
> Jerin Jacob Kollanukkaran <[email protected]>; Alex Williamson
> <[email protected]>
> Subject: Re: [PATCH v8 0/2] support for VFIO-PCI VF token interface
>
> 20/04/2020 19:37, Wang, Haiyue:
> > From: Thomas Monjalon <[email protected]>
> > > 20/04/2020 19:02, Wang, Haiyue:
> > > > From: David Marchand <[email protected]>
> > > > > I had a look at the CI, I can see we are still missing bits to handle
> > > > > the ABI failure on rte_vfio_setup_device.
> > > >
> > > > Yes, not handle it now.
> > > >
> > > > If 'rte_vfio_setup_device' can be internal, not official DPDK API, then
> > > > __rte_internal
> > > > is the best way to handle ABI issue.
> > >
> > > Please could you help finishing integration of __rte_internal?
> >
> > I thought it should be Neil ? "Yes, I'll get back to this today" ;-)
> > http://inbox.dpdk.org/dev/cajfav8ydlkv0afehqbh6kea3box0yxb3n0mngtmd4s9bmsg...@mail.gmail.com/
>
> It did not happen after several months.
> If you want to unblock your patches, I think it is safer to finish yourself.
>
Unfortunately, this __rte_internal will still make the ci fail to run when move
the function
to INTERNAL session:
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -3,6 +3,11 @@
[suppress_variable]
symbol_version = EXPERIMENTAL
+[suppress_function]
+ symbol_version = INTERNAL
+[suppress_variable]
+ symbol_version = INTERNAL
+
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -213,7 +213,6 @@ DPDK_20.0 {
rte_vfio_is_enabled;
rte_vfio_noiommu_is_enabled;
rte_vfio_release_device;
- rte_vfio_setup_device;
rte_vlog;
rte_zmalloc;
rte_zmalloc_socket;
@@ -339,3 +338,10 @@ EXPERIMENTAL {
# added in 20.05
rte_log_can_log;
};
+
+INTERNAL {
+ global:
+
+ # added in 20.05
+ rte_vfio_setup_device;
+};
Functions changes summary: 1 Removed, 0 Changed, 0 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
1 Removed function:
[D] 'function int rte_vfio_setup_device(const char*, const char*, int*,
vfio_device_info*)' {rte_vfio_setup_device@@DPDK_20.0}
Error: ABI issue reported for 'abidiff --suppr ./devtools/libabigail.abignore
--no-added-syms --headers-dir1 old_abi/include --headers-dir2 new_abi/include
old_abi/dump/librte_eal.dump new_abi/dump/librte_eal.dump'
