> I'd remove the GetVersionEx check entirely and add the comments regarding OS
> dependency to the RTE_LOG
> Of the LoadLibraryA failure below, GetVersionEx returns the Windows 8 OS
> version on newer servers
Agreed, will do in v4.
> Also, it looks like not all Win2016 servers versions support VirtualAlloc2,
> I'm using Microsoft Windows Server 2016 Datacenter Version 10.0.14393 and
> LoadLibraryA failed to load VirtualAlloc2.
I confirm this. Documentation states Windows Server 2016 is supported, but it
is at least partially incorrect, see comments in meson.build and GitHub issue:
https://github.com/MicrosoftDocs/feedback/issues/1129
How would you estimate Server 2016 support importance? Server 2019 and
Windows 10 are known to work.
--
Dmitry Kozlyuk
