> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Wednesday, April 22, 2020 22:14 > To: Wang, Haiyue <[email protected]> > Cc: dev <[email protected]>; Thomas Monjalon <[email protected]>; Richardson, > Bruce > <[email protected]>; Yigit, Ferruh <[email protected]>; Ray > Kinsella <[email protected]> > Subject: Re: [PATCH v3 1/1] eal: add internal ABI mark support > > On Wed, Apr 22, 2020 at 3:58 PM Haiyue Wang <[email protected]> wrote: > > > > Introduce __rte_internal tag to mark internal ABI function, this kind of > > function can't be called by external application. > > > > Signed-off-by: Haiyue Wang <[email protected]> > > --- > > buildtools/check-internal-syms.sh | 57 +++++++++++++++++++++++++++++ > > devtools/check-symbol-change.sh | 7 ++++ > > drivers/meson.build | 2 +- > > lib/librte_eal/include/rte_compat.h | 13 +++++++ > > lib/meson.build | 2 +- > > mk/internal/rte.compile-pre.mk | 3 ++ > > mk/target/generic/rte.vars.mk | 1 + > > 7 files changed, 83 insertions(+), 2 deletions(-) > > create mode 100755 buildtools/check-internal-syms.sh > > I did not enter the details, but I suppose this patch lacks an update > on the suppression rules so that INTERNAL versioned symbols are > skipped. > https://git.dpdk.org/dpdk/tree/devtools/libabigail.abignore > >
Added it in v4. > -- > David Marchand
