> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Friday, April 24, 2020 1:45 AM > To: Phil Yang <[email protected]> > Cc: Ananyev, Konstantin <[email protected]>; dpdk-dev > <[email protected]>; [email protected]; Bernard Iremonger > <[email protected]>; Vladimir Medvedkin > <[email protected]>; Honnappa Nagarahalli > <[email protected]>; Gavin Hu <[email protected]>; > Ruifeng Wang <[email protected]>; nd <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v2] ipsec: optimize with c11 atomic for sa > outbound sqn update > > On Thu, Apr 23, 2020 at 10:47 PM Phil Yang <[email protected]> wrote: > > > > For SA outbound packets, rte_atomic64_add_return is used to generate > > SQN atomically. This introduced an unnecessary full barrier by calling > > the '__sync' builtin implemented rte_atomic_XX API on aarch64. This > > patch optimized it with c11 atomic and eliminated the expensive barrier > > for aarch64. > > > > Signed-off-by: Phil Yang <[email protected]> > > Reviewed-by: Ruifeng Wang <[email protected]> > > Reviewed-by: Gavin Hu <[email protected]> > > > diff --git a/lib/librte_ipsec/meson.build b/lib/librte_ipsec/meson.build > > index fc69970..9335f28 100644 > > --- a/lib/librte_ipsec/meson.build > > +++ b/lib/librte_ipsec/meson.build > > @@ -6,3 +6,8 @@ sources = files('esp_inb.c', 'esp_outb.c', 'sa.c', 'ses.c', > 'ipsec_sad.c') > > headers = files('rte_ipsec.h', 'rte_ipsec_group.h', 'rte_ipsec_sa.h', > 'rte_ipsec_sad.h') > > > > deps += ['mbuf', 'net', 'cryptodev', 'security', 'hash'] > > + > > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > > +if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false > > + ext_deps += cc.find_library('atomic') > > +endif > > > The following patch has been merged in master now. You don't need this > anymore. > > commit da4eae278b56e698c64d0c39939a7a55c5b6abdd > Author: Pavan Nikhilesh <[email protected]> > Date: Sun Apr 19 15:31:01 2020 +0530 > > build: add global libatomic dependency for 32-bit clang > > Add libatomic as a global dependency when compiling for 32-bit using > clang. As we need libatomic for 64-bit atomic ops. > > Signed-off-by: Pavan Nikhilesh <[email protected]> > Acked-by: Bruce Richardson <[email protected]>
Great, we don't need to add it module by module anymore. Updated in v3. Thank you very much. Thanks, Phil
