> -----Original Message----- > From: dev <[email protected]> On Behalf Of Phil Yang > Sent: Tuesday, March 17, 2020 9:18 AM > To: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected] > Cc: [email protected]; [email protected]; > [email protected]; Honnappa Nagarahalli > <[email protected]>; Gavin Hu <[email protected]>; > Ruifeng Wang <[email protected]>; Joyce Kong > <[email protected]>; nd <[email protected]> > Subject: [dpdk-dev] [PATCH v3 03/12] eal/build: add libatomic dependency > for 32-bit clang > > When compiling with clang on 32-bit platforms, we are missing copies > of 64-bit atomic functions. We can solve this by linking against > libatomic for the drivers and libs which need those atomic ops. > > Signed-off-by: Phil Yang <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> > Reviewed-by: Gavin Hu <[email protected]> > --- > lib/librte_eal/meson.build | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build > index 4be5118..3b10eae 100644 > --- a/lib/librte_eal/meson.build > +++ b/lib/librte_eal/meson.build > @@ -20,6 +20,12 @@ endif > if cc.has_function('getentropy', prefix : '#include <unistd.h>') > cflags += '-DRTE_LIBEAL_USE_GETENTROPY' > endif > + > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > +if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false > + ext_deps += cc.find_library('atomic') > +endif > +
This should be unneeded since: https://git.dpdk.org/dpdk/commit/?id=da4eae278b56e698c64d0c39939a7a55c5b6abdd Thanks, Phil Yang > sources = common_sources + env_sources > objs = common_objs + env_objs > headers = common_headers + env_headers > -- > 2.7.4
