On Sat, Apr 25, 2020 at 8:10 AM Wang, Haiyue <haiyue.w...@intel.com> wrote: > > Hi David, > > Try to fix the issues you mentioned, except below, plan to > another patch set, I need more time to test these adding.
Thanks for working on this topic. > > ==== > > We are missing updates on devtools/check-abi-version.sh and > devtools/update_version_map_abi.py. Those two scripts can be updated later: - I suspect the first one to be broken already, - the 2nd one is for 20.11 when we will update all map files. > > More importantly on this file: > > - drivers/meson.build is not updated to check for internal symbols, see: > https://git.dpdk.org/dpdk/tree/drivers/meson.build#n166 On this point, your series is almost good to go, I would just get rid of the "experimental" mentions. I will reply on the patch. > - For fully experimental libraries, we have a special so version: > https://git.dpdk.org/dpdk/tree/drivers/meson.build#n131 > > This will apply to common drivers that will be 100% internal. > Not sure if this is an issue. This part should be fine, I want others to be aware of this. -- David Marchand
