Thanks Maxime. I just send the V2. Sorry for late. Jin
> -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Thursday, April 30, 2020 5:08 PM > To: Yu, Jin <[email protected]>; Yigit, Ferruh <[email protected]>; Tiwei > Bie <[email protected]>; Wang, Zhihong <[email protected]>; > Mcnamara, John <[email protected]>; Kovacevic, Marko > <[email protected]> > Cc: [email protected] > Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor vhost-blk > example > > > > On 4/30/20 3:42 AM, Yu, Jin wrote: > > Got it. I will check and fix it. > > Thanks, I will need the fix today, just send a v2. > If not possible to do it today, please let me know. > > Maxime > > > Thanks. > > > >> -----Original Message----- > >> From: Yigit, Ferruh <[email protected]> > >> Sent: Thursday, April 30, 2020 1:54 AM > >> To: Yu, Jin <[email protected]>; Maxime Coquelin > >> <[email protected]>; Tiwei Bie <[email protected]>; Wang, > >> Zhihong <[email protected]>; Mcnamara, John > >> <[email protected]>; Kovacevic, Marko > >> <[email protected]> > >> Cc: [email protected] > >> Subject: Re: [dpdk-dev] [PATCH] examples/vhost_blk: refactor > >> vhost-blk example > >> > >> On 2/28/2020 3:32 PM, Jin Yu wrote: > >>> Decrease the code and make it easier to read. It's useful for > >>> understanding the inflight APIs and how packed ring works. Update > >>> the RST because the packed ring patch has been merged to QEMU > master > >>> and ring_packed parameter changes to packed. > >>> > >>> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage > >>> sample") > >>> > >>> Signed-off-by: Jin Yu <[email protected]> > >>> --- > >>> doc/guides/sample_app_ug/vhost_blk.rst | 8 +- > >>> examples/vhost_blk/blk.c | 13 +- > >>> examples/vhost_blk/vhost_blk.c | 1139 ++++++++++-------------- > >>> examples/vhost_blk/vhost_blk.h | 39 +- > >>> 4 files changed, 494 insertions(+), 705 deletions(-) > >> > >> Getting following build error with 32-bit build, can you please check it: > >> > >> .../examples/vhost_blk/vhost_blk.c: In function ‘desc_payload_to_iovs’: > >> .../examples/vhost_blk/vhost_blk.c:157:9: error: cast to pointer from > >> integer of different size [-Werror=int-to-pointer-cast] > >> 157 | vva = (void *)gpa_to_vva(ctrlr, > >> | ^ > >> > >
