Hi Kevin, > -----Original Message----- > From: Kevin Traynor <ktray...@redhat.com> > Sent: Tuesday, May 5, 2020 1:55 PM > To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Cc: david.march...@redhat.com; Kevin Traynor <ktray...@redhat.com> > Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error > > gcc 10 defaults to fno-common and it reports: > > crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0): > multiple definition of `rte_kasumi_pmd_ops'; > crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here > > Fix by making rte_kasumi_pmd_ops extern in the header file. > > Signed-off-by: Kevin Traynor <ktray...@redhat.com>
Patch looks good, but you are missing fixes line and CC stable, right? Apart from that: Acked-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
