Ok, I'll modify it per you suggestion Thanks, Yuan Linsi ________________________________ 发件人: Ajit Khaparde <[email protected]> 发送时间: 2020年5月5日 11:42:20 收件人: Ferruh Yigit 抄送: Yuan,Linsi; Somnath Kotur; Lance Richardson; dpdk-dev 主题: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
On Thu, Apr 30, 2020 at 4:55 PM Ferruh Yigit <[email protected]<mailto:[email protected]>> wrote: On 4/30/2020 2:37 PM, Yuan Linsi wrote: > From: yuanlinsi01 <[email protected]<mailto:[email protected]>> > > We see a stack smashing as a result of defensive code missing. Once the > nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to > zero after doing a floor align, and we can not exit the following > receiving packets loop. And the buffers will be overwrite, then the > stack frame was ruined. > > Fix the problem by adding defensive code, once the nb_pkts is zero, just > directly return with no packets. > > Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode") > Cc: [email protected]<mailto:[email protected]> > > Signed-off-by: yuanlinsi01 > <[email protected]<mailto:[email protected]>> > Signed-off-by: rongdongsheng > <[email protected]<mailto:[email protected]>> Hi Yuan, For the sign-off tag, we need "Name Surname <[email protected]<mailto:[email protected]>>" syntax, for you I can see from mail thread that it is: "Signed-off-by: Linsi Yuan <[email protected]<mailto:[email protected]>>" Can you please share the same for the other sign-off, 'rongdongsheng'? Yuan, Can you please send the proper first-name, last-name for rongdongsheng? Thanks
