On 05/08, Phil Yang wrote: >> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber >> ports >> >> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it >> is possible when a port is started to experience a timing issue >> which prevents the link from ever being fully set up. >> >> In ixgbe_dev_link_update_share(), if the media type is fiber and the >> link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback >> to ixgbe_dev_setup_link_thread_handler() is scheduled which should >> try to set up the link and clear the flag afterwards. >> >> If the device is started before the flag is cleared, the scheduled >> callback is cancelled. This causes the flag to remain set and >> subsequent calls to ixgbe_dev_link_update_share() return >> without trying to retrieve the link state because the flag is set. >> >> In ixgbe_dev_cancel_link_thread(), after cancelling the callback, >> unset the flag on the device to avoid this condition. >> >> Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events") >> Cc: sta...@dpdk.org >> >> Bugzilla ID: 388 >> >> Signed-off-by: Phil Yang <phil.y...@arm.com> >> Signed-off-by: Lijian Zhang <lijian.zh...@arm.com> >> Reviewed-by: Gavin Hu <gavin...@arm.com> >> --- > >Ping.
This fix makes sense to me, thanks for the work. And it seems can't be applied to latest dpdk-next-net-intel cleanly, could you do a rebase? Thanks, Xiaolong > >Thanks, >Phil > ><Snip>