On 5/9/2020 5:04 AM, Xiaoyun wang wrote:
> Increase tx_queues and rx_queues non-null judgment before free tx or
> rx resources, and modify some formate for logs.
The fix is small, but it is lost in the format/syntax changes, can you please
seperate the fix.
Btw, fix is adding null check for pointer, does it case any crash if not fixed,
if so better to mention it in the commit log, to set the priority right, instead
of saying increse judgment which looks like optional change.
>
> Fixes: 54faba2295bd ("net/hinic: adds Tx queue xstats members")
Can you please double check the fixed commit, this looks unrelated. Why do you
think this is the commit that creates the code that has been fixed in this
patch?
>
> Cc: sta...@dpdk.org
> Signed-off-by: Xiaoyun wang <cloud.wangxiao...@huawei.com>
<...>
> @@ -313,6 +313,8 @@ static inline struct rte_mbuf *hinic_copy_tx_mbuf(struct
> hinic_nic_dev *nic_dev,
> mbuf = mbuf->next;
> }
>
> + dst_mbuf->pkt_len = dst_mbuf->data_len;
> +
This change is unrelated and not mentioned in the commit logs, can you please
separate it to its own patch, so it can get the description it deserves.
