>On 13/05/2020 09:58, David Marchand wrote: >> On Wed, May 13, 2020 at 3:05 AM <pbhagavat...@marvell.com> >wrote: >>> diff --git a/devtools/libabigail.abignore >b/devtools/libabigail.abignore >>> index c9ee73cb3..dfe346db4 100644 >>> --- a/devtools/libabigail.abignore >>> +++ b/devtools/libabigail.abignore >>> @@ -48,3 +48,7 @@ >>> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END >>> [suppress_variable] >>> name = rte_crypto_aead_algorithm_strings >>> + >>> +; Ignore moving internal OCTEONTX2 stable functions to INTERNAL >tag >>> +[suppress_file] >>> + soname_regexp = librte_common_octeontx2.* >> >> This syntax will work with libabigail (current master and 1.7), but >> not with older versions like the 1.6 we use in Travis: >> https://urldefense.proofpoint.com/v2/url?u=https-3A__travis- >2Dci.com_github_david-2Dmarchand_dpdk_jobs_333080901- >23L2387&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMV >sB-fmvgGV3o- >g_fjLhk5Pupi9ijohpc&m=Bl3yyReQ1bAmiy1qgiGOuuvmirDgofnVWVRfs >8oQVTU&s=vRaQQ- >sQmxRD4NkHjWkdNPN32w9wZcGPikKCwyPwugE&e= >> >> mlx common drivers were handled with the file_name_regexp >syntax. >> https://urldefense.proofpoint.com/v2/url?u=https- >3A__git.dpdk.org_next_dpdk-2Dnext-2Dnet- >2Dmlx_diff_devtools_libabigail.abignore-3Fid- >3D196ca2dfc05df7685b86aba8cdd657b4aa401ffa&d=DwICaQ&c=nKjWec >2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-fmvgGV3o- >g_fjLhk5Pupi9ijohpc&m=Bl3yyReQ1bAmiy1qgiGOuuvmirDgofnVWVRfs >8oQVTU&s=LGDNXG_tOMpX42G1jkyVVVN58qL7AIAd_QrdfgKTjNk&e= >> >> >> Rather than bump to 1.7 in Travis, my preference goes to using a >> single syntax for those exceptions. >> >> Ray, opinion? >> > >We need to aim for lowest common denominator support. >Ubuntu 20.04 shipped with 1.6 >Ubuntu 20.04 shipped with 1.2 (however I suspect we will soon be >depreciating this). > >CentOS 8/7 EPEL both ship with 1.7 > >Supporting 1.6 is a reasonable choice.
Sure, I will send a v3. Thanks, Pavan. > >Ray K
