Hi, > -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Friday, May 15, 2020 2:45 PM > To: Slava Ovsiienko <[email protected]>; Raslan Darawsheh > <[email protected]> > Cc: Ori Kam <[email protected]>; Matan Azrad <[email protected]>; > [email protected]; Suanming Mou <[email protected]> > Subject: [PATCH 1/2] net/mlx5: fix port action assert timing > > After memory optimization, some action object handles are changed to > index to save the overhead. Assertion in debug mode will be helpful > for trouble shooting. > In the current implementation, only one port action is supported in > switchdev mode for one device flow. In debug mode, an assertion will > be used to check the if the port action is none, and it should > locate before the port action resource registration but not after > it. The action index in the handle should be 0 before registration. > Or else it will always cause a failure because the port action is > registered and the index is not 0. > > Fixes: f3faf9e ("net/mlx5: convert port id action to indexed") > Cc: [email protected] > > Signed-off-by: Bing Zhao <[email protected]> > Reviewed-by: Matan Azrad <[email protected]> > Reviewed-by: Suanming Mou <[email protected]> > Acked-by: Viacheslav Ovsiienko <[email protected]> > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 71da5fb..45fa60c 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -7834,10 +7834,10 @@ struct field_modify_info modify_tcp[] = { > return -rte_errno; > memset(&port_id_resource, 0, > sizeof(port_id_resource)); > port_id_resource.port_id = port_id; > + MLX5_ASSERT(!handle->rix_port_id_action); > if (flow_dv_port_id_action_resource_register > (dev, &port_id_resource, dev_flow, error)) > return -rte_errno; > - MLX5_ASSERT(!handle->rix_port_id_action); > dev_flow->dv.actions[actions_n++] = > dev_flow->dv.port_id_action- > >action; > action_flags |= MLX5_FLOW_ACTION_PORT_ID; > -- > 1.8.3.1
Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh
