On Mon, May 11, 2020 at 11:05 AM Bruce Richardson <[email protected]> wrote: > > On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote: > > On 09-May-20 12:25 AM, Stephen Hemminger wrote: > > > Compiling a C++ application that includes directly or indirectly > > > rte_common.h will cause a warning: > > > > > > include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ > > > storage class specifier [-Wregister] > > > rte_combine32ms1b(register uint32_t x) > > > > > > C++ pickier than standard C and flags this antique usage. > > > > > > This is a bugfix please apply to 20.05. > > > The register keyword is an old K&R legacy and should be removed > > > everywhere in DPDK. For now, fix it where it hurts. > > > Checkpatch should also be able to flag use of register keyword. > > > > > > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 > > > alignment") Cc: [email protected]
> > > Signed-off-by: Stephen Hemminger <[email protected]> > Acked-by: Bruce Richardson <[email protected]> Applied, thanks. -- David Marchand
