Hi, Junyu > -----Original Message----- > From: dev <[email protected]> On Behalf Of Junyu Jiang > Sent: Wednesday, May 6, 2020 11:05 AM > To: [email protected] > Cc: Yang, Qiming <[email protected]>; [email protected] X > <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch filter > > The number of queues in queue group should be checked before using it. This > patch fixed the issue. > > Fixes: 47d460d63233 ("net/ice: rework switch filter") > Cc: [email protected] > > Signed-off-by: Junyu Jiang <[email protected]> > Tested-by: Qimai Xiao <[email protected]> > --- > drivers/net/ice/ice_switch_filter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 179430136..c2762e331 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf, > switch (action_type) { > case RTE_FLOW_ACTION_TYPE_RSS: > act_qgrop = action->conf; > + if (act_qgrop->queue_num <= 1) > + goto error;
Why do you ban the case of queue num =1? > rule_info->sw_act.fltr_act = > ICE_FWD_TO_QGRP; > rule_info->sw_act.fwd_id.q_id = > -- > 2.17.1
