06/05/2020 11:55, Ciara Power: > This patch modifies the arguments expected by the check-git-log script, > to match the format of arguments for the checkpatches script. Both > scripts now take certain argument options in the same format, making > them easier to use. > e.g. Both now take a commit ID range by "-r <range>" [...] > - usage: $(basename $0) [-h] [range] > + usage: $(basename $0) [-h] [-nX|-r range]
Why not specifying that range can be also the first argument? It is a discrepancy with what is documented in doc/guides/contributing/patches.rst > Check commit log formatting. > - The git range can be specified as a "git log" option, > - e.g. -1 to check only the latest commit. > - The default range starts from origin/master to HEAD. > + The git commits to be checked can be specified as a "git log" option, > + by latest git commits limited with -n option, or commits in the git > + range specified with -r option. > + e.g. -n1 to check only the latest commit. This line "e.g. -n1" looks disconnected from the above lines. > + The default starts from origin/master to HEAD. The rest looks OK.
