16/12/2019 20:15, Thomas Monjalon:
> The config options are updated with sed and the short in-place option.
> In order to avoid creating a backup file when using sed in-place,
> the argument was tentatively set as an empty suffix.
> On Linux, the suffix argument is optional, without space or equal before.
> On FreeBSD, the suffix argument of the in-place option is mandatory.
> This argument cannot be an empty string if no space before.
>
> In GNU sed, the short option '-i' does not expect '=' before the suffix
> argument, so it understands '=' as the file suffix.
> As a consequence, a backup file named '.config=' was created
> on Linux in the build directory.
>
> There is no common solution (without creating a function)
> to skip the backup file with GNU sed and BSD sed.
> It is solved by always creating a .config.tmp backup file
> which is removed at the end of the configuration.
>
> Fixes: 4a4a20c4775b ("devtools: support FreeBSD")
> Cc: olivier.m...@6wind.com
> Cc: sta...@dpdk.org
>
> Reported-by: Ali Alnubani <alia...@mellanox.com>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
>
> ---
>
> v1: try removing = sign
> v2: do not skip backup file
>
> ---
> devtools/test-build.sh | 78 ++++++++++++++++++++++--------------------
> 1 file changed, 40 insertions(+), 38 deletions(-)
This file should be removed in 20.11 when dropping make support.
No need for this short-live half-fix.
Marked as rejected.
