For Flow Director, we don't want to re-use a existed profile with the
same field vector and mask. Merging two different flow_type’s field
vector will also make them sharing trained rule and cause rule
interference.

For example:
issue rule A: IPV4_TCP matching tcp src&dst port 80  to queue 8
issue rule B: IPV6_TCP matching tcp src&dst port 200 to queue 20
Below behavior is found but not expected:
IPV4_TCP pkt with src&dst port 200 hits rule B and goes to queue 20
IPV6_TCP pkt with src&dst port 80  hits rule A and goes to queue 8

Signed-off-by: Yahui Cao <yahui....@intel.com>
Signed-off-by: Paul M. Stillwell Jr <paul.m.stillwell...@intel.com>
Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
---
 drivers/net/ice/base/ice_flex_pipe.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c 
b/drivers/net/ice/base/ice_flex_pipe.c
index 512ced6b8..2a7b74207 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -2811,6 +2811,12 @@ ice_find_prof_id_with_mask(struct ice_hw *hw, enum 
ice_block blk,
        struct ice_es *es = &hw->blk[blk].es;
        u8 i;
 
+       /* For FD, we don't want to re-use a existed profile with the same
+        * field vector and mask. This will cause rule interference.
+        */
+       if (blk == ICE_BLK_FD)
+               return ICE_ERR_DOES_NOT_EXIST;
+
        for (i = 0; i < (u8)es->count; i++) {
                u16 off = i * es->fvw;
 
-- 
2.13.6

Reply via email to