03/06/2020 12:47, Juraj Linkeš:
> From: Thomas Monjalon <tho...@monjalon.net>
> What about #include <rte_ethdev_trace.h> ?
>
> I only changed the .h files since that was enough to fix the issue, but I'll
> add that include as well.
[...]
> It needs to be backported, so these lines are required:
> Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual
> drivers")
> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
> Fixes: ffc905f3b856 ("ethdev: separate driver APIs")
> Fixes: 331c447ad913 ("ethdev: separate internal structures into own
> header")
> Cc: sta...@dpdk.org
>
> I didn't know which patches this fixes, so I'll add this. How should I figure
> this out? Just look at which patch(es) changed the lines I'm modifying?
You can use any git tool to search in history.
I like using gitk.
I searched when the lines you changed were introduced.
This kind of search is called pickaxe in git docs.
When you found the SHA1, you can use this git alias to generate the Fixes line:
fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'
Or even more complex to add the Cc: sta...@dpdk.org line automatically:
fixline = "!f () { git log -1 --abbrev=12 --format='Fixes: %h
(\"%s\")%nCc: %ae' $1 ; ( git tag -l --contains $1 | head -n1 | sed 's,^v,,' |
sed 's,-rc.*,,' ; for i in 1 2 ; do make showversion | cut -d'.' -f-2 ; done )
| uniq -u | head -n1 | sed 's,.*,Cc: sta...@dpdk.org,' ;}; f"
PS: your email was not prefixing my words with "> ".
Please check your mail config to make sure we clearly distinguish
questions and answers. Thanks
