On Fri, 27 Feb 2015 11:38:25 +0100 David Marchand <david.marchand at 6wind.com> wrote:
> On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang <cunming.liang at intel.com> > wrote: > v6 changes > ?- split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. > ?- rewrite rte_intr_rx_wait/rte_intr_rx_set. > ?- using vector number instead of queue_id as interrupt API params. > ?- patch reorder and split. > > > Ok, so after looking at this patchset, I would say this is the right > direction, but still this is too limited. > The ethdev part and the vfio eventfds part look acceptable to me. > But thinking about it, I could just reuse a standard event library with the > eventfds I would get from ethdev without a need for a new eal api. Also, you need to introduce a flag (in pci drv_flags?) so that application can know if poll mode interrupt will work or not on the given device before configuring it.