On 6/3/2020 4:06 PM, Ophir Munk wrote: > File drivers/net/linux/mlx5_os.h is added. It includes specific > Linux definitions such as PCI driver flags, link state changes > interrupts, link removal interrupts, etc. > > Signed-off-by: Ophir Munk <ophi...@mellanox.com> > Acked-by: Matan Azrad <ma...@mellanox.com>
<...> > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index f5d9aad..eca4472 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -41,6 +41,7 @@ > > #include "mlx5_defs.h" > #include "mlx5_utils.h" > +#include "mlx5_os.h" Assuming that you will have multiple "mlx5_os.h", one for each OS, like "linux/mlx5_os.h" & "windows/mlx5_os.h", doesn't it make sense to include it as "#include linux/mlx5_os.h", and remove relevant "-I" from CFLAGS in makefile?