On 6/9/2020 3:44 PM, Phil Yang wrote: >> -----Original Message----- >> From: dev <dev-boun...@dpdk.org> On Behalf Of Shy Shyman >> Sent: Monday, June 8, 2020 10:18 PM >> To: dev@dpdk.org >> Cc: wenzhuo...@intel.com; beilei.x...@intel.com; >> bernard.iremon...@intel.com; xavier.hu...@huawei.com >> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix error detection in MTU >> command >> >> MTU is used in testpmd to set the maximum payload size for packets. >> According to testpmd, the setting influnce RX only. >> In rte_ethdev there's no relation between MTU setting and JUMBO offload >> or >> rx_max_pkt_len. >> >> The previous fix in patch referenced below was meant to update the >> correlated variables of max_pkt_len and JUMBO offload, but by doing >> so it assumes that MTU setting can only exist when JUMBO offload >> supported in the device. For example fail-safe device does supports set MTU >> and doesn't support JUMBO offload, and in this case, though set MTU >> succeeds, an error message is still printed since the JUMBO packet >> offload is disabled. >> >> The fix separates the two conditions to make sure the error >> triggers only in case the set_mtu action actually failed. >> >> Fixes: 150c9ac2df13 ("app/testpmd: update Rx offload after setting MTU") >> Cc: xavier.hu...@huawei.com >> >> Signed-off-by: Shy Shyman <s...@mellanox.com> > > Reviewed-by: Phil Yang <phil.y...@arm.com> >
Applied to dpdk-next-net/master, thanks.