23/06/2020 08:45, Tal Shnaiderman: > > 22/06/2020 09:55, [email protected]: > > > +struct internal_config * > > > +rte_eal_get_internal_configuration(void) > > > +{ > > > + return &internal_config; > > > +} > > > > This function should be private to EAL, no rte_ prefix. > > When creating the new functions I based the pattern on the already existing > function > rte_eal_get_configuration() which encapsulates the formally global rte_config. > > Do we want to remove the rte_ prefix from this function as well?
No, don't change the existing function. It could be a separate cleanup.
