Hi David,
> -----Original Message-----
> From: Coyle, David <[email protected]>
> Sent: Tuesday, June 23, 2020 11:14 AM
> To: [email protected]; Doherty, Declan <[email protected]>; De
> Lara Guarch, Pablo <[email protected]>; Trahe, Fiona
> <[email protected]>; Zhang, Roy Fan <[email protected]>;
> Ananyev, Konstantin <[email protected]>
> Cc: [email protected]; [email protected]; Yigit, Ferruh
> <[email protected]>; Ryan, Brendan <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Richardson, Bruce <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Coyle, David
> <[email protected]>; O'loingsigh, Mairtin <[email protected]>
> Subject: [PATCH v2 5/6] test/crypto: add DOCSIS security test cases
>
> Add uplink and downlink DOCSIS unit test cases and vectors, to test
> the combined DOCSIS Crypto-CRC support that has been added to the
> rte_security and rte_cryptodev libraries.
>
> Signed-off-by: David Coyle <[email protected]>
> Signed-off-by: Mairtin o Loingsigh <[email protected]>
...
> +static int
> +test_docsis_proto_uplink(int i, struct docsis_test_data *d_td)
> +{
> + struct rte_security_op *sec_op;
> + struct rte_security_docsis_op *doc_op;
> + struct crypto_testsuite_params *ts_params = &testsuite_params;
> + struct crypto_unittest_params *ut_params = &unittest_params;
> + uint8_t *plaintext, *ciphertext;
> + uint8_t *iv_ptr;
> + int cipher_len = 0;
> + int crc_len = 0, crc_data_len;
Minor comment. These "int" should be "unsigned int", as they are not going to
hold a negative value.
> + int ret = TEST_SUCCESS;
