26/05/2020 12:08, guohongzhi:
> From: Hongzhi Guo <[email protected]>
>
> 0xffff is invalid for IPv4 checksum(RFC1624)
>
> Fixes: 6006818cfb26 ("net: new checksum functions")
> Cc: [email protected]
>
> Reviewed-By: Morten Brørup <[email protected]>
> Acked-by: Olivier Matz <[email protected]>
>
> Signed-off-by: Hongzhi Guo <[email protected]>
The Signed-off should be in chronological order, before reviews.
As suggested in previous patch, the title should be
net: fix IPv4 checksum
I am doing above modifications while merging.
More advices about submitting patches:
- use -v2, -v3, etc when sending new versions
- add a changelog below the line ---
- use --in-reply-to to keep all versions threaded
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
> {
> uint16_t cksum;
> cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> - return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> + return (uint16_t)~cksum;
> }
Applied, thanks
