On Tue, 23 Jun 2020 18:11:45 -0700 [email protected] wrote: > From: Long Li <[email protected]> > > When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the > reference count in its callback function hn_rx_buf_free_cb, because the > reference count is already decreased by rte_pktmbuf. Doing it twice may result > in underflow and driver may never send an ack packet over vmbus to host. > > Also declares rxbuf_outstanding as atomic, because this value is shared > among all receive queues. > > Signed-off-by: Long Li <[email protected]>
Good catch. DPDK ought to have a real refcnt type like the kernel. One that traps on underflow. Acked-by: Stephen Hemminger <[email protected]>
