hi, yunjian
On 6/3/2020 8:55 PM, wangyunjian wrote:
From: Yunjian Wang <wangyunj...@huawei.com>
Fix return value, using -EAGAIN instead of 0 when the callback is busy
and using -ENOENT instead of 0 when the callback is not found.
Fixes: a753e53d517b ("eal: add device event monitor framework")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
---
lib/librte_eal/common/eal_common_dev.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_dev.c
b/lib/librte_eal/common/eal_common_dev.c
index 6b465bc..5f5e333 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -536,9 +536,14 @@ static int cmp_dev_name(const struct rte_device *dev,
const void *_name)
free(event_cb);
ret++;
} else {
- continue;
+ ret = -EAGAIN;
+ break;
}
}
Suggest add a blank line here if there will be another version.
+ /* this callback is not be registered */
+ if (ret == 0)
+ ret = -ENOENT;
+
rte_spinlock_unlock(&dev_event_lock);
return ret;
}
Look good and thanks.
Acked-by: Jeff Guo <jia....@intel.com>
