Hi Akhil, Please see my response inline.
Thanks Ankur >-----Original Message----- >From: Akhil Goyal <[email protected]> >Sent: Thursday, July 2, 2020 1:53 AM >To: Ankur Dwivedi <[email protected]>; [email protected] >Cc: [email protected]; Anoob Joseph <[email protected]> >Subject: [EXT] RE: [PATCH 7/7] test/crypto: use generic cryptotests for OCTEON >TX PMDs > >External Email > >---------------------------------------------------------------------- >Hi Anoob/Ankur, >> From: Anoob Joseph <[email protected]> >> >> This patch enables the generic crypto tests for OCTEON TX PMDs. >> Reomves the PMD specific tests. > >Spell check. [Ankur] Will address this in v2. > >> >> Signed-off-by: Ankur Dwivedi <[email protected]> >> Signed-off-by: Anoob Joseph <[email protected]> >> --- >> app/test/test_cryptodev.c | 769 >> +--------------------------------------------- >> 1 file changed, 2 insertions(+), 767 deletions(-) >> > >Please split this patch into two patches. When I try to apply this patch, The >contents of this patch gets changed. I believe a lot of similar lines of Code >make git confused and it jumble up the code. >So probably, you can remove the PMD specific cases in one patch and >Testsuite in the other one. [Ankur] Will address this in v2. > >Rename the title of the patch as >test/crypto: use generic testsuite for OCTEON TX/TX2 [Ankur] Will address this in v2.
