> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Friday, July 3, 2020 11:39 PM > To: Phil Yang <[email protected]> > Cc: dev <[email protected]>; Olivier Matz <[email protected]>; David > Christensen <[email protected]>; Honnappa Nagarahalli > <[email protected]>; Ruifeng Wang > <[email protected]>; nd <[email protected]> > Subject: Re: [dpdk-dev] [PATCH] mbuf: use c11 atomics for refcnt operations > > On Thu, Jun 11, 2020 at 12:26 PM Phil Yang <[email protected]> wrote: > > > > Use c11 atomics with explicit ordering instead of rte_atomic ops which > > enforce unnecessary barriers on aarch64. > > > > Signed-off-by: Phil Yang <[email protected]> > > Reviewed-by: Ruifeng Wang <[email protected]> > > I did not look at the details, but this patch is refused by the ABI > check in Travis.
Thanks, David. The ABI issue is the name of 'rte_mbuf_ext_shared_info::refcnt_atomic' changed to 'rte_mbuf_ext_shared_info::refcnt' at rte_mbuf_core.h. I made this change just to simplify the name of the variable. Revert the 'rte_mbuf_ext_shared_info::refcnt' to refcnt_atomic can fix this issue. I will update it in v2. Thanks, Phil > > > -- > David Marchand
