16/06/2020 10:16, Junfeng Guo: > This patch defines new RSS offload types for IPv6 prefix with 32, 48, > 64 bits of both SRC and DST IPv6 address. > > Signed-off-by: Junfeng Guo <[email protected]> > --- > lib/librte_ethdev/rte_ethdev.h | 51 ++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 631b146bd..5a7ba36d8 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -538,6 +538,9 @@ struct rte_eth_rss_conf { > #define ETH_RSS_L4_DST_ONLY (1ULL << 60) > #define ETH_RSS_L2_SRC_ONLY (1ULL << 59) > #define ETH_RSS_L2_DST_ONLY (1ULL << 58) > +#define ETH_RSS_L3_PRE32 (1ULL << 57) > +#define ETH_RSS_L3_PRE48 (1ULL << 56) > +#define ETH_RSS_L3_PRE64 (1ULL << 55)
PRE32, 48 and 64 are not obvious. Why is it needed? At least, please add comments for the values of this API. Do we want to continue with the RTE_ prefix missing? Can't we add the prefix for the new values? Note: ethdev maintainers were not Cc'ed. This reason is enough to nack the patch.
