> -----Original Message----- > From: Honnappa Nagarahalli <[email protected]> > Sent: Wednesday, July 8, 2020 1:15 PM > To: Phil Yang <[email protected]>; [email protected] > Cc: [email protected]; Ruifeng Wang <[email protected]>; nd > <[email protected]>; [email protected]; [email protected]; Honnappa > Nagarahalli <[email protected]>; nd <[email protected]> > Subject: RE: [PATCH 1/2] eal: remove redundant code > > <snip> > > > Subject: [PATCH 1/2] eal: remove redundant code > > > > The event status has been cleaned up by the CAS operation when we free > > the event data, so there is no need to set it to invalid after that. > > > > Fixes: 49e2f374e45a ("eal/linux: support external Rx interrupt") > > Cc: [email protected] > > Cc: [email protected] > This is not a bug fix. I think it is not worth backporting, suggest removing > this.
OK. > > > > > Signed-off-by: Phil Yang <[email protected]> > > Reviewed-by: Ruifeng Wang <[email protected]> > Otherwise > > Reviewed-by: Honnappa Nagarahalli <[email protected]> > > > --- > > lib/librte_eal/linux/eal_interrupts.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > b/lib/librte_eal/linux/eal_interrupts.c > > index 16e7a7d..2f369dc 100644 > > --- a/lib/librte_eal/linux/eal_interrupts.c > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > @@ -1431,7 +1431,6 @@ rte_intr_free_epoll_fd(struct rte_intr_handle > > *intr_handle) > > if (rte_epoll_ctl(rev->epfd, EPOLL_CTL_DEL, rev->fd, rev)) { > > /* force free if the entry valid */ > > eal_epoll_data_safe_free(rev); > > - rev->status = RTE_EPOLL_INVALID; > > } > > } > > } > > -- > > 2.7.4
