Please Cc those who participated in the review previously.
Adding Ray, Jerin, David.
10/07/2020 16:46, Vladimir Medvedkin:
> New data type to manipulate 512 bit AVX values.
[...]
> +#ifdef __AVX512F__
> +
> +#define RTE_X86_ZMM_SIZE (sizeof(__m512i))
> +#define RTE_X86_ZMM_MASK (ZMM_SIZE - 1)
Why do you use tabs?
> +
> +typedef union __rte_x86_zmm {
Double space
> + __m512i z;
> + ymm_t y[RTE_X86_ZMM_SIZE / sizeof(ymm_t)];
> + xmm_t x[RTE_X86_ZMM_SIZE / sizeof(xmm_t)];
> + uint8_t u8[RTE_X86_ZMM_SIZE / sizeof(uint8_t)];
> + uint16_t u16[RTE_X86_ZMM_SIZE / sizeof(uint16_t)];
> + uint32_t u32[RTE_X86_ZMM_SIZE / sizeof(uint32_t)];
> + uint64_t u64[RTE_X86_ZMM_SIZE / sizeof(uint64_t)];
> + double pd[RTE_X86_ZMM_SIZE / sizeof(double)];
> +} __rte_aligned(RTE_X86_ZMM_SIZE) __rte_x86_zmm_t;
> +
> +#endif /* __AVX512F__ */
You were supposed to undef the macros above.
Vladimir, after your recent contributions,
it seems you are not interested in details.
Please understand we have to maintain a project with consistency
and good doc. Please pay attention, thanks.
