On 13/07/2020 16:46, Ruifeng Wang wrote:
>
>> -----Original Message-----
>> From: Ferruh Yigit <[email protected]>
>> Sent: Monday, July 13, 2020 9:51 PM
>> To: Honnappa Nagarahalli <[email protected]>; Ruifeng Wang
>> <[email protected]>; Vladimir Medvedkin
>> <[email protected]>; Ray Kinsella <[email protected]>
>> Cc: [email protected]; Ferruh Yigit <[email protected]>
>> Subject: [PATCH] lib: fix build for missing RCU library dependency
>>
>> 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency
>> should
>> be reflected to build system.
>>
>> Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")
>>
>> Signed-off-by: Ferruh Yigit <[email protected]>
>> ---
>> Cc: [email protected]
> Hi Ferruh,
>
> Thanks for fixing this.
> Although I didn't reproduce the building issue, this patch is obviously valid.
>
> Regards.
> /Ruifeng
>
> Reviewed-by: Ruifeng Wang <[email protected]>
Was already there for meson/ninja.
Acked-by: Ray Kinsella <[email protected]>
>> ---
>> lib/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile b/lib/Makefile index 4b981f505e..8f5b68a2d4 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -59,7 +59,7 @@ DEPDIRS-librte_rib := librte_eal librte_mempool
>> DIRS-$(CONFIG_RTE_LIBRTE_FIB) += librte_fib DEPDIRS-librte_fib :=
>> librte_eal librte_rib
>> DIRS-$(CONFIG_RTE_LIBRTE_LPM) += librte_lpm -DEPDIRS-librte_lpm :=
>> librte_eal librte_hash
>> +DEPDIRS-librte_lpm := librte_eal librte_hash librte_rcu
>> DIRS-$(CONFIG_RTE_LIBRTE_ACL) += librte_acl DEPDIRS-librte_acl :=
>> librte_eal
>> DIRS-$(CONFIG_RTE_LIBRTE_MEMBER) += librte_member
>> --
>> 2.25.4
>