On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno <amore...@redhat.com> wrote: > >> + if (ret > UINT8_MAX) { > >> + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS > >> response 0x%" PRIx64 "\n", ret); > > > > There's a coding style issue here: > > CHECK:CAMELCASE: Avoid CamelCase: <PRIx64> > > Could you fix this? > > I did see this one as well. It also seems new because PRIx64 is widely used > in DPDK. > > find -iname *.c | xargs grep -i "PRIx64" | wc -l > 520 > > So, ether we have to modify the script to ignore this one or change all 520 > cases, right?
This is a false positive. We won't drop use of this standard macro because checkpatch is not happy with it. I don't see how to silence this warning but I can see that the kernel uses this macro: so I guess people are simply ignoring this one. -- David Marchand