[dpdk-dev] ?????? [dpdk-stable] [PATCH V2] net/bonding: delete redundant code

?????????? Fri, 17 Jul 2020 19:30:24 -0700

Ok, my signature is :
&nbsp; &nbsp; &nbsp; Dongyang Pan <[email protected]&gt;
Thanks!





------------------&nbsp;????????&nbsp;------------------
??????:                                                                         
                                               "Ferruh Yigit"                   
                                                                 
<[email protected]&gt;;
????????:&nbsp;2020??7??17??(??????) ????8:46
??????:&nbsp;"??????????"<[email protected]&gt;;
????:&nbsp;"Wei Hu 
(Xavier)"<[email protected]&gt;;"dev"<[email protected]&gt;;"stable"<[email protected]&gt;;
????:&nbsp;Re: [dpdk-stable] [PATCH V2] net/bonding: delete redundant code



On 7/17/2020 12:22 PM, Wei Hu (Xavier) wrote:
&gt; Reviewed-by: Wei Hu (Xavier) <[email protected]&gt;
&gt; 
&gt; 
&gt; On 2020/7/4 9:22, Wei Hu (Xavier) wrote:
&gt;&gt;
&gt;&gt;
&gt;&gt; On 2020/7/4 9:15, [email protected] wrote:
&gt;&gt;&gt; From: pandongyang <[email protected]&gt;
&gt;&gt;&gt;
&gt;&gt;&gt; The function valid_bonded_port_id() has already contains function
&gt;&gt;&gt; rte_eth_dev_is_valid_port(), so delete redundant check.
&gt;&gt;&gt;
&gt;&gt;&gt; Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
&gt;&gt;&gt; Cc: [email protected]
&gt;&gt;&gt;
&gt;&gt;&gt; Signed-off-by: pandongyang <[email protected]&gt;

Hi pandongyang,

Can you please provide the sign-off in following format:
Name Surname <[email protected]&gt;

We need this to be able to accept the patch.

Thanks,
ferruh


&gt;&gt; Reviewed-by: Wei Hu (Xavier) <[email protected]&gt;
&gt;&gt;&gt; ---
&gt;&gt;&gt; v1 -&gt; v2: Adjust commit info
&gt;&gt;&gt; ---
&gt;&gt;&gt;&nbsp;&nbsp; drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
&gt;&gt;&gt;&nbsp;&nbsp; 1 file changed, 6 deletions(-)
&gt;&gt;&gt;
&gt;&gt;&gt; diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c 
&gt;&gt;&gt; b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; index b77a37ddb..339374337 100644
&gt;&gt;&gt; --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
&gt;&gt;&gt; @@ -1675,9 +1675,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = 
&amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = 
dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) 
!= 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if 
(bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return 
-1;
&gt;&gt;&gt;&nbsp;&nbsp; @@ -1704,9 +1701,6 @@ 
&gt;&gt;&gt; rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; dev = 
&amp;rte_eth_devices[port];
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; internals = 
dev-&gt;data-&gt;dev_private;
&gt;&gt;&gt;&nbsp;&nbsp; -&nbsp;&nbsp;&nbsp; if (check_for_bonded_ethdev(dev) 
!= 0)
&gt;&gt;&gt; -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return -1;
&gt;&gt;&gt; -
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; /* Device must be stopped to 
set up slow queue */
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if 
(dev-&gt;data-&gt;dev_started)
&gt;&gt;&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; return 
-1;
&gt;&gt;
&gt;

[dpdk-dev] ?????? [dpdk-stable] [PATCH V2] net/bonding: delete redundant code

Reply via email to