Hi Jerin, > -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > > On Mon, Jul 27, 2020 at 1:28 AM Ori Kam <or...@mellanox.com> wrote: > > > > > diff --git a/app/test-regex/hello_world.rof2 b/app/test- > regex/hello_world.rof2 > > new file mode 100644 > > index 0000000..fb7db75 > > --- /dev/null > > +++ b/app/test-regex/hello_world.rof2 > > @@ -0,0 +1,45 @@ > > +# > > +# rof_version: 2 > > +# > > +# date:20200210_164643 > > +# > > +# rxp_compiler:5.7.18007 > > Please don't check-in vendor/driver specific file formats in the main > repository. > See below.
I fully agree with you that in normal cases such files should not be part of the main repository, but this case is different from the regard that this test can't be run without vendor specific files. I expect that each vendor will add its own file for this repo. > > > +# > > +# rof_revision:0 > > +# > > +2, 0x00000000, 0x0000000004055254 > > +3, 0x00000000, 0x0000000007055254 > > +1, 0x00000005, 0x0000000000aa0008 > > +1, 0x00000006, 0x00000000dddd00aa > > +4, 0x00010010, 0x0000000000000000 > > +4, 0x00010011, 0x0000000000000000 > > +4, 0x00010012, 0x0000000000000000 > > +5, 0x00010010, 0x0000000000000000 > > +5, 0x00010011, 0x0000000000000000 > > +5, 0x00010012, 0x0000000000000000 > > +6, 0x00000000, 0x6c6c65680040bd82 > > +6, 0x00000001, 0x6f77206f0040bd82 > > +6, 0x00000002, 0x00646c720040bd62 > > +6, 0x00000003, 0x0000000100403a48 > > +6, 0x00000004, 0x00000001003b3c1f > > +6, 0x00000005, 0x0000000000000000 > > +6, 0x00000006, 0x0000000000000000 > > +6, 0x00000007, 0x0000000000000000 > > +6, 0x00d30000, 0x0000000000000000 > > +6, 0x00e401e5, 0xbdb9180002000000 > > +6, 0x00e80000, 0x31ac75f69abc779c > > +6, 0x00ec0000, 0xabe575e975011cf4 > > +6, 0x00ed0000, 0x38bf9e2967d22ac4 > > +6, 0x00f00000, 0x34f501ce6aa8a034 > > +6, 0x00f10000, 0x85e40fd9e10676d7 > > +6, 0x00f40000, 0x1258c0a059dc9464 > > +6, 0x00f401e5, 0x680262622a400800 > > +6, 0x00f50000, 0x000d32453675686d > > +6, 0x00f60000, 0x4136d69d550adc7a > > +6, 0x00f70000, 0x6db55b9daab1c703 > > +4, 0x00010010, 0x0000000087a5837c > > +4, 0x00010011, 0x00000000d75b7cab > > +4, 0x00010012, 0x000000000884a03a > > +5, 0x00010010, 0x0000000087a5837c > > +5, 0x00010011, 0x00000000d75b7cab > > +5, 0x00010012, 0x000000000884a03a > > + > > +Running the Tool > > +---------------- > > + > > +The tool has a number of command line options. Here is the sample > command line: > > + > > +.. code-block:: console > > + > > + ./build/app/testregex -w 83:00.0 -- --rules > > app/test-regex/hello_world.rof2 > --data app/test-regex/input.txt --job 100 > > Instead of giving the binary rule format, Primary option could to be > compile the rule by the application itself. > If the driver does not have such capability then the application can > look for binary rule file in such case please don't host > binary rules in dpdk.org. > Like I said above, in Mellanox case the rule must be precompiled, (I think the same goes for number of other vendors) and it doesn’t look complete code, if we will just give the code, and the user will have to download files from other places. I think for this specific example and since the file is small we should allow it. What do you think? > > > -- > > 1.8.3.1 > >
