26/07/2020 21:19, Akhil Goyal: > > > > > > [Adam] The ret variable value (signed) is not returned directly, please > > > check the > > rest of this function in src > > > code. This is just checked to calculate how many ops were enqueued. And > > > if all > > checks skip (meaning the > > > op was not processed by sym crypto, asym crypto nor compression), we > > should note the user that the > > > actual op was NOT enqueued. That's why ret is set to -1. > > [Fiona] ok. makes sense thanks. In that case > > Acked-by: Fiona Trahe <fiona.tr...@intel.com> > > Cc: sta...@dpdk.org > > Applied to dpdk-next-crypto
This patch should not have been merged. The explanation is missing. This is the commit log: "This patch fixes the uninitialized variable bug in QAT PMD." We don't even know what is the consequence and the scope. That's not acceptable for a fix.