>-----Original Message----- >From: Eads, Gage <gage.e...@intel.com> >Sent: Friday, July 10, 2020 3:43 PM >To: McDaniel, Timothy <timothy.mcdan...@intel.com>; jer...@marvell.com >Cc: mattias.ronnb...@ericsson.com; dev@dpdk.org; Van Haaren, Harry ><harry.van.haa...@intel.com> >Subject: RE: [PATCH 14/27] event/dlb: add PMD self-tests > >Hi Tim, > >> +#include <rte_memory.h> >> +#include <rte_memzone.h> >> +#include <rte_launch.h> >> +#include <rte_eal.h> >> +#include <rte_per_lcore.h> >> +#include <rte_lcore.h> >> +#include <rte_debug.h> >> +#include <rte_ethdev.h> >> +#include <rte_cycles.h> >> +#include <rte_eventdev.h> >> +#include <rte_pause.h> > >Minor nit: I did a test build, looks like rte_ethdev.h, rte_per_lcore.h, and >rte_pause.h are not required, but rte_mbuf.h and rte_mempool.h are. > >> +int >> +test_dlb_eventdev(void) >> +{ >> + const char *dlb_eventdev_name = "event_dlb"; > >"event_dlb" -> "dlb_event" > >This self-test also needs to be added to app/test/test_eventdev.c. > >Thanks, >Gage
Hi Gage, I have implemented all of the suggested changes. They will be available in patchset 3. Thanks, Tim