Hi Beilei > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Xing, Beilei > Sent: Friday, July 31, 2020 10:30 AM > To: Sun, GuinanX <guinanx....@intel.com>; Guo, Jia <jia....@intel.com>; > dev@dpdk.org > Cc: Sun, GuinanX <guinanx....@intel.com>; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Guinan Sun > > Sent: Thursday, July 30, 2020 6:25 PM > > To: Xing, Beilei <beilei.x...@intel.com>; Guo, Jia > > <jia....@intel.com>; dev@dpdk.org > > Cc: Sun, GuinanX <guinanx....@intel.com>; sta...@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > If the PF driver supports the new speed reporting capabilities then > > use link_event_adv instead of link_event to get the speed. > > > > Fixes: 2a73125b7041 ("i40evf: fix link info update") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Guinan Sun <guinanx....@intel.com> > > --- > > v2: > > * Modify commit log. > > * Add code comments. > > * Delete useless codes. > > --- > > drivers/net/i40e/base/virtchnl.h | 16 +++++++++++- > > drivers/net/i40e/i40e_ethdev_vf.c | 42 > +++++++++++++++++++++++++++++-- > > 2 files changed, 55 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/base/virtchnl.h > > b/drivers/net/i40e/base/virtchnl.h > > index 4f498ca45..9c64fd469 100644 > > --- a/drivers/net/i40e/base/virtchnl.h > > +++ b/drivers/net/i40e/base/virtchnl.h > > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, > > virtchnl_vsi_resource); > > #define VIRTCHNL_VF_OFFLOAD_ENCAP 0X00100000 > > #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X00200000 > > #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000 > > - > > +/* Define below the capability flags that are not offloads */ > > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED 0x00000080 > > You defined the new capability VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the > patch, but didn't request the capability for i40evf?
This capability is given by i40e kernel pf if VIRTCHNL_VF_CAP_ADV_LINK_SPEED is defined. So vf doesn't need to request it. Thanks. Shougang